Feature atmos #1
Conversation
README.md
Outdated
| of subtenantid/uid, e.g. | ||
| 640f9a5cc636423fbc748566b397d1e1/uid1 | ||
|
|
||
| -atmos,--atmos the tool is used to delete Atmos namespace |
There was a problem hiding this comment.
don't have a short-option here (leave it null) in the CLI option
README.md
Outdated
| -e,--endpoint <URI> the endpoint to connect to, including | ||
| protocol, host, and port | ||
| protocol, host, and port or Atmos access |
There was a problem hiding this comment.
don't need the additional note here (endpoint is the right term in either S3 or Atmos)
README.md
Outdated
|
|
||
| prefix | ||
|
|
||
| -port,--atmosport <port> Atmos access point port (default 80) |
There was a problem hiding this comment.
don't need this (port is in the URI)
README.md
Outdated
| -port,--atmosport <port> Atmos access point port (default 80) | ||
|
|
||
| -s,--secret-key <secret-key> the secret key or Atmos Shared secret if | ||
| option -atmos is used |
There was a problem hiding this comment.
don't need additional note here (secret key is the right term)
| @@ -41,6 +41,38 @@ | |||
| import java.util.concurrent.LinkedBlockingDeque; | |||
| import java.util.concurrent.atomic.AtomicBoolean; | |||
| import java.util.concurrent.atomic.AtomicLong; | |||
| // Atmos imports | |||
There was a problem hiding this comment.
need to organize imports (in IJ, Ctrl-Alt-O)
| private static Options options() { | ||
| Options options = new Options(); | ||
| options.addOption(Option.builder().longOpt("stacktrace").desc("displays full stack trace of errors").build()); | ||
| options.addOption(Option.builder("h").longOpt("help").desc("displays this help text").build()); | ||
| options.addOption(Option.builder("atmos").longOpt("atmos") |
There was a problem hiding this comment.
leave the builder call empty (no short-option)
| @@ -118,25 +176,32 @@ public void run() { | |||
| } | |||
|
|
|||
| private static void printHelp() { | |||
| new HelpFormatter().printHelp("java -jar bucket-wipe.jar [options] <bucket-name>", options()); | |||
| new HelpFormatter().printHelp("java -jar bucket-wipe.jar [options] <bucket-name or atmos directory path>", options()); | |||
There was a problem hiding this comment.
leave this the same (this will just be the bucket)
| options.addOption(Option.builder("p").longOpt("prefix").hasArg().argName("prefix") | ||
| .desc("deletes only objects under the specified prefix").build()); | ||
| options.addOption(Option.builder("o").longOpt("atmos-object-space").desc("atmos only: use atmos object space " + |
There was a problem hiding this comment.
add in description of "p" option, " or Atmos namespace path"
| @@ -163,38 +228,157 @@ private static Options options() { | |||
| private boolean hierarchical; | |||
| private String sourceListFile; | |||
|
|
|||
| // *********Atmos related | |||
| private boolean atmosOption; | |||
| private String remoteroot; // remoteroot is Atmos' bucket name | |||
There was a problem hiding this comment.
remove this - namespace path will just be prefix
| private long dirCount; | ||
| private long fileCount; | ||
| private SimpleDirectedGraph<TaskNode, DefaultEdge> graph; | ||
| private Set<TaskNode> failedItems; |
There was a problem hiding this comment.
remove this.. tracking failed items may run out of memory
…into feature-atmos
* code cleanup - hopefully the graph logic is a bit more clear
atmos support to bucket-wipe.